Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collada and Assimp test for default animation names #476

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

onurtore
Copy link
Contributor

🦟 Bug fix

Fixes #393

Summary

Checks default animation name assigned to collada and assimp loaded meshes. Requires #413 to assimp test to pass.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Add paranthesis

Signed-off-by: Onur Berk Töre <[email protected]>
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #476 (80c98a0) into main (b0001bf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #476   +/-   ##
=======================================
  Coverage   81.07%   81.07%           
=======================================
  Files          79       79           
  Lines        9679     9679           
=======================================
  Hits         7847     7847           
  Misses       1832     1832           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we target a lower version ?

@onurtore
Copy link
Contributor Author

onurtore commented Nov 10, 2022

Can we target a lower version ?

Do not think so, because of faulty PR on my side, the functionality for this test to be passed added into main branch with a different PR, gz-common5 will results with failing tests because there isn't any default name assignment.

Are there any other branches I can target?

@onurtore
Copy link
Contributor Author

onurtore commented Nov 15, 2022

@ahcorde
Friendly ping

@ahcorde ahcorde enabled auto-merge (squash) November 16, 2022 11:33
@ahcorde ahcorde merged commit d5364b6 into gazebosim:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants