Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate messages in downstream builds #339

Merged
merged 46 commits into from
Jun 23, 2023
Merged
Changes from 1 commit
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
1c2b31a
Create "core" directory
mjcarroll May 11, 2023
887d1e9
Remove "filesystem"
mjcarroll May 11, 2023
12ceb1e
Split message factory into static and non-static parts
mjcarroll May 11, 2023
bf8ce61
Add cmake functions
mjcarroll May 11, 2023
14eb585
Move everything that depends on message definitions to "compiled"
mjcarroll May 11, 2023
1b10efa
Exercise the compiled pipeline
mjcarroll May 11, 2023
922ef93
Generate messages in "compiled" package
mjcarroll May 12, 2023
c98833f
Implement header-only conversion functions
mjcarroll May 12, 2023
03bf781
Fix tool installation
mjcarroll May 17, 2023
6b90cfd
Fix CMake
mjcarroll May 17, 2023
71de7f2
Lint
mjcarroll May 18, 2023
945285b
Address reviewer feedback
mjcarroll May 22, 2023
4b066b9
Fix typos
mjcarroll May 22, 2023
558eaf1
Add examples
mjcarroll May 30, 2023
078e8ed
Add READMEs for the examples
mjcarroll May 30, 2023
2d8ab98
Fix tests
mjcarroll May 30, 2023
08eddae
Update copyright year
mjcarroll Jun 1, 2023
d215951
Update usage
mjcarroll Jun 1, 2023
6d3c94e
Add explicit message generation dependencies
mjcarroll Jun 1, 2023
51b6b49
Update migration guide
mjcarroll Jun 1, 2023
e4de3b6
Fix factory test
mjcarroll Jun 1, 2023
ee7eb4f
Add functional header
mjcarroll Jun 1, 2023
4453cf4
Grammar
mjcarroll Jun 5, 2023
e35843c
Update examples/generating_custom_msgs/main.cc
mjcarroll Jun 1, 2023
e5df01b
Windows compat
mjcarroll Jun 5, 2023
edb9d05
Fix Windows visibility
mjcarroll Jun 9, 2023
2ff4edf
Also link messages to test
mjcarroll Jun 12, 2023
0428d8d
Fix compiler warnings
mjcarroll Jun 20, 2023
6e9c02f
Fix Windows build
mjcarroll Jun 14, 2023
ee80d3c
Fix path separator on Windows
mjcarroll Jun 20, 2023
c7f393a
Add migration note about ruby
mjcarroll Jun 20, 2023
3ccce92
Update CMake documentation
mjcarroll Jun 22, 2023
7cf741a
Refactor common string operations into functions
mjcarroll Jun 22, 2023
263bf11
Style nit
mjcarroll Jun 22, 2023
9dfab82
Document target_link_messages
mjcarroll Jun 22, 2023
1684866
Lint
mjcarroll Jun 22, 2023
85c8ea6
Restore const char* setter
mjcarroll Jun 22, 2023
60200f3
Change to array rather than map
mjcarroll Jun 22, 2023
48810d9
Windows typo
mjcarroll Jun 22, 2023
9e4ea2a
Fix visibility logic
mjcarroll Jun 22, 2023
6c55def
Remove conflicting visibility
mjcarroll Jun 22, 2023
82331b3
Completely remove visibility from target_link_messages
mjcarroll Jun 22, 2023
f0fda37
Drop template from conversions
mjcarroll Jun 22, 2023
a3e0182
Address reviewer feedback
mjcarroll Jun 22, 2023
52f7e12
Change to implptr
mjcarroll Jun 22, 2023
a775cb5
Update core/generator/Generator.cc
mjcarroll Jun 23, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix compiler warnings
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
mjcarroll committed Jun 23, 2023
commit 0428d8deccec0d0dc88b1adeeddc56a385e287cd
1 change: 0 additions & 1 deletion compiled/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -56,7 +56,6 @@ if (TARGET UNIT_Factory_TEST)
endif()

if (TARGET UNIT_Utility_TEST)
target_include_directories(UNIT_Utility_TEST PRIVATE ${PROJECT_BINARY_DIR}/gz_msgs_gen)
target_link_messages(TARGET UNIT_Utility_TEST MSG_TARGETS gz_msgs_msgs)
endif()