-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standalone gz sdf
executable
#1539
Merged
Merged
Changes from 17 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
d823820
Implement gz sdf as standalone executable
scpeters ce14de5
Merge branch 'sdf15' into scpeters/gz_sdf_executable
scpeters aafefa1
Merge branch 'sdf15' into scpeters/gz_sdf_executable
azeey 891e490
Updating ruby script to use standalone executable (#1489)
sauk2 f4fc058
Merge branch 'sdf15' into scpeters/gz_sdf_executable
azeey c4f155f
Moved tests and deleted redundant files
sauk2 756ba94
Updated cmake to build moved test
sauk2 193a1f1
Skipped creation of static lib for standalone exe creation
sauk2 699c5ae
Added includes
sauk2 7b27baa
Restoring previous files to save commit history
sauk2 9714658
Removed gz files from cmd
sauk2 5dae7f4
Moved cmd files by preserving history
sauk2 71edff4
Added namespace to cmd line hooks
sauk2 d834355
Changed types from int to bool for flags
sauk2 22d78cc
Defined test config path as alias and populated it from cmake
sauk2 40576fe
Merge branch 'sdf15' into gz_sdf_executable
j-rivero 51e8485
Removed GZ_PROGRAM dependency from sdf_descriptions target
sauk2 b15e767
Added concise description and validation to -g option
sauk2 3505c3d
Removed function to print gz version
sauk2 eacb7b3
Added dependency on -p for print specific flags
sauk2 3f35036
Added back files for eventual git rename
sauk2 5fdfb42
Moved cmd source files
sauk2 0f40dd5
Added modification to cmd source files
sauk2 8d3b4d5
Merge branch 'sdf15' into gz_sdf_executable
sauk2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the removal of
PROJECT_LIBRARY_TARGET_NAME
from DEPENDS intended?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sauk2 this final question and we are good to go !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry, I forgot to reply. This change was made by @azeey as a part of this commit (615048c) of this PR (#1489). He'd be the best person to clarify so tagging him here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're adding a dependency on
gz-sdformat-sdf
below, which is ultimately what is used to generate these files, this target no longer needs to depend onPROJECT_LIBRARY_TARGET_NAME