Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning and optimization #1101

Merged
merged 4 commits into from
Dec 25, 2023
Merged

warning and optimization #1101

merged 4 commits into from
Dec 25, 2023

Conversation

gboeing
Copy link
Owner

@gboeing gboeing commented Dec 25, 2023

This PR:

  • optimizes the _make_overpass_polygon_coord_strs function with some refactoring
  • warns user if the geometry (boundary area) is much larger than max query area size because this can cause slow performance a) during quadrat cutting to subdivide the geometry, and b) during Overpass downloading because OSMnx must make many requests.

Copy link

codecov bot commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d61a218) 97.84% compared to head (3a2aac4) 97.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1101      +/-   ##
==========================================
+ Coverage   97.84%   97.92%   +0.07%     
==========================================
  Files          28       28              
  Lines        2506     2505       -1     
==========================================
+ Hits         2452     2453       +1     
+ Misses         54       52       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gboeing gboeing merged commit dde24f3 into main Dec 25, 2023
10 checks passed
@gboeing gboeing deleted the feature branch December 25, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant