Remove previously deprecated functionality #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be removed in the v2.0.0 release
deprecation refinements
…vor of bbox tuple argument
deprecate north, south, east, west arguments throughout package in favor of bbox tuple argument
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## v2 #1113 +/- ##
==========================================
- Coverage 97.86% 97.79% -0.08%
==========================================
Files 28 26 -2
Lines 2625 2356 -269
==========================================
- Hits 2569 2304 -265
+ Misses 56 52 -4 ☔ View full report in Codecov by Sentry. |
…, and make osm_xml module private
…oords function params throughout, and make which_result param optionally a list for graph_from place and features_from_place functions
|
The first pre-release OSMnx v2 beta has been released. Testers needed! See #1123 for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes previously deprecated functionality for v2.0.0 to streamline the API and make it more user friendly.
which_resultparam so it is consistently able to accept a list throughout the packageosm_xmlmodule to_osm_xmlto make it private/internal as all its functionality is private (theioandgraphmodules expose its public functionality)bbox_from_pointfunction return bbox as a tuple of floats for consistency with rest of packageSee also #1106