Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename private _downloader module, remove unneeded _api module, and fix unreachable code #1114

Merged
merged 7 commits into from
Jan 20, 2024

Conversation

gboeing
Copy link
Owner

@gboeing gboeing commented Jan 20, 2024

See also #1106

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (845d32b) 97.79% compared to head (b703c53) 97.87%.
Report is 2 commits behind head on v2.

❗ Current head b703c53 differs from pull request most recent head a3b3dc7. Consider uploading reports for the commit a3b3dc7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #1114      +/-   ##
==========================================
+ Coverage   97.79%   97.87%   +0.08%     
==========================================
  Files          26       25       -1     
  Lines        2356     2358       +2     
==========================================
+ Hits         2304     2308       +4     
+ Misses         52       50       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gboeing gboeing mentioned this pull request Jan 20, 2024
13 tasks
@gboeing gboeing merged commit 389cc96 into v2 Jan 20, 2024
4 of 5 checks passed
@gboeing gboeing deleted the http branch January 20, 2024 06:51
@gboeing
Copy link
Owner Author

gboeing commented May 3, 2024

The first pre-release OSMnx v2 beta has been released. Testers needed! See #1123 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant