Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages #1131

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Improve error messages #1131

merged 4 commits into from
Feb 13, 2024

Conversation

gboeing
Copy link
Owner

@gboeing gboeing commented Feb 13, 2024

This PR improves the error messages throughout the package.

See also #1106

@gboeing gboeing changed the base branch from main to v2 February 13, 2024 04:47
@gboeing gboeing mentioned this pull request Feb 13, 2024
13 tasks
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (dcc6c47) 97.93% compared to head (e2a4125) 97.94%.
Report is 19 commits behind head on v2.

Files Patch % Lines
osmnx/utils_graph.py 71.42% 2 Missing ⚠️
osmnx/distance.py 66.66% 1 Missing ⚠️
osmnx/truncate.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##               v2    #1131   +/-   ##
=======================================
  Coverage   97.93%   97.94%           
=======================================
  Files          25       25           
  Lines        2423     2429    +6     
=======================================
+ Hits         2373     2379    +6     
  Misses         50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gboeing gboeing merged commit 38eecc7 into v2 Feb 13, 2024
6 of 7 checks passed
@gboeing gboeing deleted the msg branch February 13, 2024 05:30
@gboeing
Copy link
Owner Author

gboeing commented May 3, 2024

The first pre-release OSMnx v2 beta has been released. Testers needed! See #1123 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant