Optimize _remove_polygon_holes and _create_gdf for performance #1205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #1200 by optimizing the _remove_polygon_holes function to improve performance when dealing with complex geometries. Additionally, it enhances the efficiency of the _create_gdf function.
Changes proposed in this pull request:
The functionality remains the same, just faster on complex polygons.
ox.features.features_from_point((46.18, 74.42), tags={"natural": "water"}, dist=50000)
The CHANGELOG.md has been updated to reflect these changes.
The changes have been tested and all tests pass with the exception of mypy failed on osmnx/plot.py:856, but this was an existing issue and not related to the changes in this PR. As such, --no-verify was used to bypass the GitHub precommit hooks.