[Enhancement] Enabling floating Info bar #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasvillaverde
changed the title
lucasvillaverde
commented
Jul 14, 2024
Comment on lines
+99
to
+110
| @Composable | ||
| private fun ZePagesLazyList( | ||
| paddingValues: PaddingValues, | ||
| lazyListState: LazyListState, | ||
| slots: Map<ZeSlot, ZeConfiguration>, | ||
| sendPageToBadgeAndDisplay: (ZeSlot) -> Unit, | ||
| slotToBitmap: (ZeSlot) -> Bitmap, | ||
| customizeSponsorSlot: (ZeSlot) -> Unit, | ||
| customizeSlot: (ZeSlot) -> Unit, | ||
| resetSlot: (ZeSlot) -> Unit, | ||
| modifier: Modifier = Modifier, | ||
| ) { |
There was a problem hiding this comment.
Extracting the list in a separate method, this will allow us to enable the preview functionality in the future without depending on the VM
lucasvillaverde
commented
Jul 14, 2024
|
|
||
| if (message.isNotEmpty()) { | ||
| InfoBar( | ||
| modifier = Modifier.align(Alignment.BottomCenter), |
There was a problem hiding this comment.
To change the InfoBar position, just change the Alignment on this line. e.g. if you want to put it at the top the aligment would be Aligment.TopCenter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enabling floating Info bar to avoid list auto scrolling to the top
Solves #391
How It Was Tested
Manually tested according to the videos.
Screenshot/Gif
TEST_WEATHER.webm
FLOATING.INFOBAR.mp4
Screenshot Name