Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Patch for gplugins r2ladder example #97

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

daquintero
Copy link
Contributor

@daquintero daquintero commented Jun 8, 2024

I still can't find how to sort out, but this at least enables the implementation towards the DAC R2R example in gplugins

layer (2, 0) not found
layer (0, 0) not found
layer (2, 0) not found
layer (0, 0) not found
layer (2, 0) not found
layer (0, 0) not found
layer (2, 0) not found
layer (0, 0) not found
layer (2, 0) not found
layer (0, 0) not found
layer (2, 0) not found
layer (0, 0) not found
layer (2, 0) not found
layer (0, 0) not found
layer (2, 0) not found
layer (0, 0) not found
layer (2, 0) not found
layer (0, 0) not found
layer (2, 0) not found
layer (0, 0) not found
layer (2, 0) not found
layer (0, 0) not found
layer (2, 0) not found
layer (0, 0) not found
layer (2, 0) not found
layer (0, 0) not found

related to gdsfactory/gplugins#356

Copy link

sourcery-ai bot commented Jun 8, 2024

🧙 Sourcery is reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@joamatab
Copy link
Contributor

Hi Dario,

do you still need it with this PR?

#98

@daquintero
Copy link
Contributor Author

Hi Joaquin, hope you're well! Will mark as a draft until I can get round to this again to test the hdl21 gplugin with gdsfactory 8 upgrade - likely in a week or two!

@daquintero daquintero marked this pull request as draft July 10, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants