-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes for building on windows/msys2 #1408
base: master
Are you sure you want to change the base?
Conversation
giuspen
commented
Feb 2, 2025
- version locally the script geany-plugins-release.py so far hosted in the wiki
- applied fix for building without signing (missing key/certificate in the filesystem)
- applied fix to geanygendoc/docs/Makefile.am
- applied fix to lsp/src/lsp-server.c
- applied fix for languages binaries not being generated
- changed version num to 2.1
Could you please split each item to its own commit? We prefer having smaller more specific commits leading to the final stage. Of course each commit should be complete in regard of what it is meant to achieve, but each of these should try and be small. It also gives you the opportunity to actually explain why you changed something, both to help reviewers and future understanding of why a change has been made. |
@@ -45,6 +45,7 @@ | |||
# include "spawn/lspunixoutputstream.h" | |||
#endif | |||
|
|||
#include <unistd.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change on purpose?
If so, @techee should add it upstream as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem to add but is it actually needed @giuspen ? The plugin seemed to build without it on my machine at least.