Move remove EXTERNALLY-MANAGED to handler

geerlingguy · Sep 20, 2024 · 0cd78d0 · 0cd78d0
1 parent ceea3d9
commit 0cd78d0
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 13 deletions.
diff --git a/handlers/main.yml b/handlers/main.yml
@@ -0,0 +1,15 @@
+---
+- name: Remove EXTERNALLY-MANAGED
+  block:
+    # Remove EXTERNALLY-MANAGED if pip_externally_managed is true and python3 version is 3.11 or higher.
+    # Related issue: https://github.com/geerlingguy/ansible-role-pip/issues/57
+    - name: Get installed python3 version
+      ansible.builtin.shell: python3 --version | awk '{split($2, a, "."); print a[1] "." a[2]}'
+      register: py3ver
+      changed_when: false
+
+    - name: Ensure "{{ 'absent' if not pip_externally_managed else 'present' }}" of EXTERNALLY-MANAGED's Python base environments
+      ansible.builtin.file:
+        path: "/usr/lib/python{{ py3ver.stdout }}/EXTERNALLY-MANAGED"
+        state: "{{ 'absent' if not pip_externally_managed else 'touch' }}"
+      when: py3ver is defined and py3ver.stdout is version_compare('3.11', '>=')
diff --git a/tasks/main.yml b/tasks/main.yml
@@ -1,21 +1,9 @@
 ---
-# Remove EXTERNALLY-MANAGED if pip_externally_managed is true and python3 version is 3.11 or higher.
-# Related issue: https://github.com/geerlingguy/ansible-role-pip/issues/57
-- name: Get installed python3 version
-  ansible.builtin.shell: python3 --version | awk '{split($2, a, "."); print a[1] "." a[2]}'
-  register: py3ver
-  changed_when: false
-
-- name: Ensure "{{ 'absent' if not pip_externally_managed else 'present' }}" of EXTERNALLY-MANAGED's Python base environments
-  ansible.builtin.file:
-    path: "/usr/lib/python{{ py3ver.stdout }}/EXTERNALLY-MANAGED"
-    state: "{{ 'absent' if not pip_externally_managed else 'touch' }}"
-  when: py3ver is defined and py3ver.stdout is version_compare('3.11', '>=')
-
 - name: Ensure Pip is installed.
   package:
     name: "{{ pip_package }}"
     state: present
+  notify: Remove EXTERNALLY-MANAGED
 
 - name: Ensure pip_install_packages are installed.
   pip: