Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc/main stufe 4 - Diesen PR NICHT mergen (nach Stufe 3) !!! #127

Draft
wants to merge 108 commits into
base: main-stufe-3
Choose a base branch
from

Conversation

f-peverali
Copy link
Contributor

@f-peverali f-peverali commented Jun 26, 2024

Stufe 4 Upgrade

Diesen PR NICHT mergen (nach Stufe 3) !!!

Version: 4.0.0-rc2

Diesen PR NICHT mergen (nach Stufe 3) !!!

Date: 26.6.2024

Description

This is a Pullreuqest that requires an increase in the Version number. Therefore, multiple outside-github, related Task have to be performed and checked.

All jobs with an x in the boxes were performed to the best of knowledge.

Pre-Merge Activities

  • This PR refers to a versioned Branch with a name and a version number in the form of N.n.n, e.g. "TC_3.2.1".

  • This PR has a clean meaningful committ history. Minor committs or committs without descirption have been squashed, at the latest now.

  • The ./github/workflows/main.yml refers to the correct Firetly Terminal and SUSHI Version.

    Firely Terminal Pipeline 0.4.0.

    SUSHI Versions 3.5.0.

  • By running the Release_Publish.py script, release version and date was updated accordingly. The script ran without errors.

  • Eventually, increase the dependency of to newer Basis Modul (package and sushi-config)

  • New Release Notes were created, aglined to the committ history and cleaned. In Github, go to

    • -> Releases then -> Draft a new release with the Modul Name and Version, then
    • -> Target the main-Branch and ->enter a new Tag according to the Version, then click.
    • Click -> Generate Release notes , ->Adjust them if necessary and -> Copy/Paste the Details in the RealeaseNotes.md of the very Branch you want to merge.
    • Finally -> Save as Draft

Merge and Publishing

  • With the updated Version, Dates, and Release Notes (as described above) with the last committ into the Branch you want to merge.
  • In GitHub -> Actions the ->CI (FHIR Validation) workflow terminates successfully.
  • Add the Approve / the PR gets posivitly reviewed by a collegue.
  • Merge (without squash) the PR, delete the Branch.

Post-Merge Activities

  • Go to the corresponding SIMPLIFIER Project and -> Github -> Reimport the project.
  • Go to the corresponding SIMPLIFIER Project and -> Packages -> Expand the Dropdown for Create -> Create new package for the project.
    • With the corresponding version number, and
    • The Release notes (from above) and a compare-link to the previous Release.
    • Unlist the old package by -> clicking on the old package, -> go to Admininstration and -> click on Unlist
  • Publish the previosuly drafteted Release, including version number, on GitHub.
  • Provide / Archive the IG in the corresponding gh-pages branch of the GitHub project.
    • Checkout the Branch (no need to merge it later).
    • Export from Simplifier via -> Guides -> Expand the Modul ... -> Export
    • Unpack the zip, remove the packages folder (because its kinda big), and move everything else to a (version coressponding) new folder in the branch folder structure.
    • committ the branch.

Finished

MaxMTheilig and others added 30 commits January 12, 2024 16:11
PTDATA-828 Hinweis zur Musterchargennummer
auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)
AMTS use case diagram
progress on Infomodell
progress on use cases
Infomodell only for MS
auto-generated diagrams by GitHub Action after source code change
* infomodell medication

first full draft of Infomodell

* progress on info and usecases

* auto-generated diagrams by GitHub Action after source code change

* replaced ClinicalUseDefinition with RiskAssessment
created abstract Laboruntersuchung class

---------

Co-authored-by: Max Theilig <[email protected]>
Co-authored-by: MaxMTheilig <[email protected]>
* infomodell medication

first full draft of Infomodell

* progress on info and usecases

* auto-generated diagrams by GitHub Action after source code change

* replaced ClinicalUseDefinition with RiskAssessment
created abstract Laboruntersuchung class

---------

Co-authored-by: Max Theilig <[email protected]>
Co-authored-by: MaxMTheilig <[email protected]>
f-peverali and others added 7 commits April 5, 2024 13:08
* removed MS on .id
fixes anfisk-261

* auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)

* removed MS on .id
fixes anfisk-261

---------

Co-authored-by: patrick-werner <[email protected]>
#124)

* Klarifizierung Dosis-Rate Quantity und Ratio (Beispiele, Must-Support)

* auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)

* Update Resources/input/fsh/ISiKMedikationsVerordnung.fsh

* Update Resources/input/fsh/ISiKMedikationsVerordnung.fsh

* auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)

* update releasenotes

---------

Co-authored-by: Stefan Lang <[email protected]>
Co-authored-by: f-peverali <[email protected]>
Co-authored-by: f-peverali <[email protected]>
* rm MS Flag on partOf

* auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)

* update releasenotes

---------

Co-authored-by: f-peverali <[email protected]>
* applied changes from KBV Kommentierung

* auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)

* feat: Änderungen aus den KBV Kommentaren eingepflegt

* PR link added

* fixing build

* auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)

* fix: UcumUndSctDoseFormVS now uses children of Unit dose

* auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)

* fix: removed sct codes from MedicationQuantity Profile

* fix: removed sct codes & ucum VS

* auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)

* feat: applied MS comments from PR review

* Update ImplementationGuide/markdown/ReleaseNotes.md

Co-authored-by: f-peverali <[email protected]>

* fix: added 1.. to ISiKMedikament.ingredient.strength.denominator

* auto-generated FHIR files by GitHub Actions (CI FSH to FHIR Validation)

---------

Co-authored-by: patrick-werner <[email protected]>
Co-authored-by: f-peverali <[email protected]>
@f-peverali f-peverali marked this pull request as draft June 26, 2024 12:25
@patrick-werner patrick-werner deleted the rc/main-stufe-4 branch September 9, 2024 11:34
…nto rc/main-stufe-4

# Conflicts:
#	Resources/fsh-generated/resources/StructureDefinition-ISiKMedikationsInformation.json
#	Resources/fsh-generated/resources/StructureDefinition-ISiKMedikationsVerordnung.json
#	Resources/input/fsh/ISiKAMTSBewertung.fsh
#	Resources/input/fsh/ISiKMedikationsInformation.fsh
#	Resources/input/fsh/ISiKMedikationsVerordnung.fsh
# Conflicts:
#	ImplementationGuide/markdown/UseCases/AMTS/AMTS_Diagramme.md
#	ImplementationGuide/markdown/Zusammenfassung.md
#	Resources/fsh-generated/fsh-index.json
#	Resources/fsh-generated/fsh-index.txt
#	Resources/input/fsh/ISiKMedikament.fsh
#	Resources/input/fsh/ISiKMedikationsInformation.fsh
#	Resources/input/fsh/ISiKMedikationsVerabreichung.fsh
#	Resources/input/fsh/ISiKMedikationsVerordnung.fsh
#	Resources/input/fsh/valueSets.fsh
@patrick-werner patrick-werner reopened this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants