Fix issue 780 #781
Merged
Fix issue 780 #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #781 +/- ##
=======================================
Coverage 78.84% 78.84%
=======================================
Files 113 113
Lines 1494 1494
Branches 3 3
=======================================
Hits 1178 1178
Misses 316 316 ☔ View full report in Codecov by Sentry. |
cquiroz
reviewed
Aug 9, 2023
| @@ -67,7 +67,7 @@ object Dataset { | |||
| Option.when(localDate.getYear >= 0 && localDate.getYear <= 9999)(Filename(site, localDate, index)) | |||
|
|
|||
| private val DateFormatter: DateTimeFormatter = | |||
| DateTimeFormatter.ofPattern("yyyyMMdd") | |||
| DateTimeFormatter.ofPattern("uuuuMMdd") | |||
There was a problem hiding this comment.
Uhh interesting, is this working on the js side of things?
There was a problem hiding this comment.
Yes, now passes both JVM and JS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #780. Format pattern
yyyyswitches year 0 to year 1 for some very good reason.