Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move config methods from odb #787

Merged
merged 1 commit into from
Aug 20, 2023
Merged

Move config methods from odb #787

merged 1 commit into from
Aug 20, 2023

Conversation

cquiroz
Copy link
Collaborator

@cquiroz cquiroz commented Aug 18, 2023

These methods are in lucuma-odb but we need them in explore too

@mergify mergify bot added the core label Aug 18, 2023
Copy link
Contributor

@toddburnside toddburnside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.13% 🎉

Comparison is base (f1613f4) 78.78% compared to head (897329c) 78.91%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #787      +/-   ##
==========================================
+ Coverage   78.78%   78.91%   +0.13%     
==========================================
  Files         113      113              
  Lines        1494     1494              
  Branches        3        3              
==========================================
+ Hits         1177     1179       +2     
+ Misses        317      315       -2     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cquiroz cquiroz merged commit e6dcb22 into master Aug 20, 2023
8 checks passed
@cquiroz cquiroz deleted the binning-calculation branch August 20, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants