Add scalar angle multiplication #815
Conversation
tpolecat
changed the title
cquiroz
force-pushed
the
scalar-angle-multiplication
branch
from
c56bbe0
to
1d23bda
Compare
| * Scalar multiplication of this angle and double precission number `a`. Approximate | ||
| * @group Operations | ||
| */ | ||
| def *?(a: Double): Angle = |
There was a problem hiding this comment.
I made it *? to denote that is approximate. not sure if it is a good idea, WDYT?
There was a problem hiding this comment.
We just document it when it's inexact. Pretty much anything involving Double is inexact by definition.
| * @group Operations | ||
| */ | ||
| def *(a: Long): Angle = | ||
| Angle.fromMicroarcseconds(toMicroarcseconds * a) |
There was a problem hiding this comment.
Unfortunately this overflows when a gets large. You may need to go to BigDecimal and renormalize it back into 0..360° before constructing the return value.
scala> Angle.Angle90 * 4000000
val res14: lucuma.core.math.Angle = 0
scala> Angle.Angle90 * 40000000
val res15: lucuma.core.math.Angle = 230290448384
There was a problem hiding this comment.
Thanks I pushed a new commit doing as you suggest and some tests
| * Scalar multiplication of this angle and double precission number `a`. Approximate | ||
| * @group Operations | ||
| */ | ||
| def *?(a: Double): Angle = |
There was a problem hiding this comment.
We just document it when it's inexact. Pretty much anything involving Double is inexact by definition.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #815 +/- ##
==========================================
+ Coverage 78.64% 78.98% +0.33%
==========================================
Files 113 113
Lines 1494 1494
Branches 3 3
==========================================
+ Hits 1175 1180 +5
+ Misses 319 314 -5 ☔ View full report in Codecov by Sentry. |
No description provided.