remove old workflow state fields #1459
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpolecat
commented
Oct 25, 2024
| @@ -72,7 +71,7 @@ trait GeneratorParamsService[F[_]] { | |||
|
|
|||
| def selectAll( | |||
| programId: Program.Id, | |||
| minStatus: ObsStatus = ObsStatus.New, | |||
| // minStatus: ObsStatus = ObsStatus.New, | |||
There was a problem hiding this comment.
This parameter filters the observations we consider, but it's unused thus far (the only call uses the default status of New, which effectively means no filtering). Because workflow status isn't [yet] computable in the database maybe we could just hardcode it to filter out inactive observations? Inactivity will be coded in a column in a followup PR.
tpolecat
commented
Oct 25, 2024
| @@ -1,690 +0,0 @@ | |||
| // Copyright (c) 2016-2023 Association of Universities for Research in Astronomy, Inc. (AURA) | |||
There was a problem hiding this comment.
The validations field was removed and is now on workflow.validationErrors. The associated tests (in observation_workflow) include the tests here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - IGNORE
This removes
ObsStatus,ObsActiveStatus, and theforReviewfield, all of which are subsumed byObservationWorkflowState. A followup PR will add an internal user state that allows the user to set the workflow state toInactiveandReadywhen appropriate.Explore should remove references to these things in preparation for the schema change.