Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCHED-404: First cleanup #277

Merged
merged 3 commits into from
Jul 24, 2023
Merged

SCHED-404: First cleanup #277

merged 3 commits into from
Jul 24, 2023

Conversation

stroncod
Copy link
Contributor

No description provided.

sraaphorst
sraaphorst approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@sraaphorst sraaphorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start to the cleanup! 👍

scheduler/core/components/optimizer/base.py

from dataclasses import dataclass
from datetime import timedelta
from typing import Mapping, List, Optional, Union
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder: we can omit Union from now on and just use | as in int | str for example.

@stroncod stroncod marked this pull request as ready for review July 21, 2023 20:00
@stroncod stroncod merged commit 82ccfb4 into main Jul 24, 2023
2 checks passed
@stroncod stroncod deleted the SCHED-404 branch August 29, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sraaphorst sraaphorst sraaphorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stroncod @sraaphorst