Improve timing in collector nightevents #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is this faster somehow ? I don't understand the reason of the change, can you elaborate a bit? |
|
Exactly, it is faster, the Time translation from astropy to datetime (to_datetime with an specific ZoneInfo) objects takes a couple of minutes and creating the events from scratch using pandas to have the same datetime objects takes just a few seconds. Computing the time.time() I get. |
stroncod
approved these changes
Jul 18, 2024
| for start, end in zip(dt_time_starts, dt_time_ends)] | ||
| local_times = [dt.tz_convert(self.site.timezone) for dt in utc_times] | ||
| utc_times = [dt.to_pydatetime() for dt in utc_times] | ||
| local_times = [dt.to_pydatetime() for dt in local_times] |
There was a problem hiding this comment.
does the native python datetimes objects retain the timezone after transformation?
|
Great, thanks for the explanation. Approved! |
stroncod
deleted the
GSCHED-709-improve-timing-in-collector-night-events-creation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change nightevents utc and local time lists to be created from scratch using pandas