GSCHED-710 modified visibility slot idx format #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stroncod
approved these changes
Jul 22, 2024
stroncod
deleted the
GSCHED-710-change-visibility-snapshot-data-format-to-improve-redis-cache-efficiency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed visibility data format to store data ranges in Redis instead of big lists.
Please be careful, this change may break things if Redis cache is not removed, since it is not compatible with the old format.
This change improves the timing in the schedule visibility calculation when using Redis data for the default parameters (semester visibility true and start date Oct 1, 2018) going from aprox 2 minutes to 1.5 minutes. Also the amount of stored data decreases to about a quarter of the original size.
Tests will fail if the Redis cache is not cleaned.