Issue #448 #497
Open
Issue #448 #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gh the table affiliation
…d adjustments on i18n
…of enrollments pdf
…m affiliation and program_level
…mitee_table and tests
# Conflicts: # db/schema.rb
# Conflicts: # Gemfile # Gemfile.lock # db/schema.rb
…and program_levels_controller.rb
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -62,6 +62,38 @@ def professor_advisements_with_points_show_column(record, options) | |||
| resp.html_safe | |||
| end | |||
|
|
|||
| def professor_institutions_show_column(record, options) | |||
There was a problem hiding this comment.
Method professor_institutions_show_column has 26 lines of code (exceeds 25 allowed). Consider refactoring.
| body = "" | ||
| count = 0 | ||
| affiliations.each do |affiliation| | ||
| count += 1 |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
# Conflicts: # app/controllers/concerns/shared_pdf_concern.rb # app/controllers/enrollments_controller.rb # app/models/ability.rb # config/locales/navigation.pt-BR.yml # config/navigation.rb
|
Code Climate has analyzed commit 099fbf9 and detected 3 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 81.6% (50% is the threshold). This pull request will bring the total coverage in the repository to 71.0% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.