Fixes a bug with the bitset hash #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 6, 2023 22:26
|
Did this end up fixing genaray/Arch.Extended#26? If so, could you add the tests from that issue in an Arch.Extended PR as well? Or I can. |
genaray
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a component type has a ID that borders a uint size (32, 64, 96) the bitset isnt big enough
I'm just +1 to the highestId
I tried removing the highestId find foreach, and just using
ComponentRegistry.SizeHowever this broke my new tests and the
HashSimilaritytest as the ComponentRegistry isnt actually setup during these testsFor now heres a fix