Add docs #25
Merged
Add docs #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
YuWei-CH
commented
Jun 7, 2024
YuWei-CH
commented
- Add StaticData setup in INSTALL/install.sh
- Comment new functions
- Update troubleshooting in README
Instead of cleaning up every hour it cleans once daily
genericdata
reviewed
Jun 7, 2024
| 0 1 * * * /bin/bash /home/reform/reformWeb/cleanup.sh | ||
|
|
||
| # Create local File folder for test site | ||
| mkdir -p /home/reform/reformWeb/staticData |
There was a problem hiding this comment.
Do we add this to .gitignore? Especially when the static files are so large. Probably too large for github. We can investigate using the test data from the reform repo, https://github.com/gencorefacility/reform/tree/master/test_data.
|
@YuWei-CH You're good to merge this after you add the contents of staticdata to a .gitignore. Also there are merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.