Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the representation of regulatory reactions to use 'has_small_molecule_regulator' activity #204

Closed
2 of 3 tasks
ukemi opened this issue Sep 14, 2022 · 8 comments
Closed
2 of 3 tasks
Assignees

Comments

@ukemi
Copy link

ukemi commented Sep 14, 2022

Currently when we import a regulatory reaction from Reactome, we create a construct where the entity that enables the regulated reaction (RMF) binds the regulator and the binding MF regulates the RMF. We also create a process that the binding is part of to infer the regulatory process. A simple example of this can be seen in the 'Fructose catabolism' pathway.
http://noctua.geneontology.org/editor/graph/gomodel:R-HSA-70350
https://reactome.org/PathwayBrowser/#/R-HSA-70350

In this pathway, the KHK enzyme enables ketohexokinase activity that is activated by K+ and is inhibited by ADP.

  • To be consistent with the latest GO_CAM modeling procedure. The binding construct can be replaced by the new has_small_molecule_regulator relations. In this case the ketohexokinase activity would has_small_molecule_activator K+ and has_small_molecule_inhibitor ADP. See the modified copy of the model here:
    http://noctua.geneontology.org/editor/graph/gomodel:62f58d8800006682
  • Since the relation is restricted to small molecules, we should only allow this if the regulator has a ChEBI identifier and is not a protein (UniProt) or complex (?). For example in this reaction, R-HSA-168935, the negative regulators are a protein (DHX58) and a complex (ISG15:DDX58 conjugate). We would not want to allow these as small molecule regulators.
  • We should also not allow nucleic acids as regulators. I can't put my finger on one, but they would be children of: CHEBI:33696.
    • Adding to the problem, while Reactome uses ChEBI terms for various polynucleotide instances as identifiers to make these instances compliant with the REACTO ontology, we do not use CHEBI:33696 anywhere, because we were aiming for more fine-grained terms, e.g., mRNA, microRNA, dsDNA, etc.
@ukemi ukemi mentioned this issue Sep 14, 2022
16 tasks
@deustp01
Copy link
Collaborator

Defer from action in connection with GO-CAM build from Reactome ver 82 - do it later

@ukemi
Copy link
Author

ukemi commented Mar 9, 2023

Checked:

  • glycolysis pfk and pk- look good
  • gluconeogenesis pc and fbp- look good
  • RMP biosynthesis adenylosuccinate synthetase- looks good IMP dehydrogenase looks good
  • Pyruvate metabolism- pyruvate kinase activity and [pyruvate dehydrogenase (lipoamide)] phosphatase activity look good
  • Regulation of pyruvate dehydrogenase (PDH) complex looks good for small molecules. But see below.

@ukemi
Copy link
Author

ukemi commented Mar 9, 2023

Shex failures, at least some of them are due to this:
geneontology/go-shapes#299

@ukemi
Copy link
Author

ukemi commented Mar 9, 2023

@dustine32 was this only done for the import or for all the existing models? I notice that the ticket seems to include a retrofit.

@ukemi
Copy link
Author

ukemi commented Mar 9, 2023

In this pathway, R-HSA-204174 the controller RXRA:PPARD:atRA (R-HSA-5634107_R-HSA-203946_controller) is now missing any relation to R-HSA-203946. It positively regulates it. It doesn't get the relation because it is not a small molecule. Is there a way that when a controller is a protein complex (has part some protein or set of proteins) we could infer 'enzyme activator/inhibitor activity' enabled by the complex or protein?

@dustine32
Copy link
Collaborator

Orphan glutathione should not even be in model R-HSA-204174. It was part of a drug rxn that was filtered out.

@ukemi
Copy link
Author

ukemi commented Jun 19, 2023

On the June 19, 2023 'weeds' call, we made the decision to go ahead and allow the drug identifiers that are sneaking in in this load. In the future, the drugs will be tagged explicitly in the BioPax file and will be filtered in that manner rather than by identifier space. ping @deustp01 @dustine32

@ukemi
Copy link
Author

ukemi commented Jun 19, 2023

On the June 19, 2023 'weeds' call, we decided to allow the reactions that are upstream or downstream of the main pathway to maintain the 'old'/incomplete representation of regulators. Even though this is not ideal, it puts more of the model in alignment with GO-CAM standard practice. In the future we will get feedback from the larger community about whether linking models will be done in a timely manner and if so, we will not need to represent these in the models the way they are currently represented. If the larger community does not solve this problem in a timely manner, then we will solve this problem specifically for the imports. ping @deustp01 @dustine32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants