-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query for Complexes without an active subunit in Reactome #327
Comments
We will take a look at these results on the 'weeds' call. |
I haven't looked at the list yet - do you want to wait until next week? By then I should have a much better sense of what needs to be patched and whether some of the patching could be at least partly automated. |
Also see #302 |
We could, but I have found a couple issues with the query. It seems that there are complexes that aren't controllers/enablers/catalysts included, which inflates the numbers. Let's try to clean that up and then get into the real weeds of the biology next week, ok? |
If it's possible to generate a list of these irregular ones, that would be useful. |
It would probably be easier to modify the query. It looks like step 1 didn't work right. |
For example, R-HSA-109857 is a binding reaction without a catalyst. We will eventually merge it into the next reaction since it is substrate binding, but it should not be in the results of this query. |
Hi @dustine32 Side note: |
PS. Let me know if you want a separate ticket for the side note. |
I'm imagining a script could take the list of components of a complex, remove all items that are not gene products (EWAS class members), and uniquify** that list. If only one EWAS is left, that is the candidate active unit. If more than one, human review would be needed to determine whether there is an emergent function. **But if two different EWASs both derive from the same UniProt gene product and differ in their modifiedResidue attributes, that's a distinction that is not of interest to GO-CAM (it's a kind of homodimer at the granularity of GO-CAM, I think) and we should figure out how to take one of them as the active unit |
Good question about the homodimer. Since in many cases we are summing up to the level of the gene, maybe just take the gene. But this would result in a curation policy to never curate at the level of modified or processed forms. In MGI I think we would use a PRO id if it were available for these. So is it a homodimer? |
@ukemi Thanks for the examples! I see in the first example the complex in the report is actually a regulator, not a catalyst. This quickly points to the report bug, which is checking active sites for any reaction's |
@ukemi It might be best to clarify this request in the existing #302 ticket you referred to earlier since that also involves breaking down complexes into single protein enablers. Basically, the code would try shedding all ions (could I just discard all |
Yes, absolutely. Most small molecules / chemicals that form complexes with gene products may be ions, but the ley difference for Reactome and GO-CAM is gene-product versus not-gene-product.
Yes again, where the process exactly is to identify the UniProt IDs associated with all EWAS instances in the complex, and uniquify on those UniProt IDs. |
@deustp01 when you say "they aren't implemented yet" you refer to PRO in GO-CAMs? Because I've had the Reactome-mapped terms for quite some time. |
@nataled We need some work on the Reactome end, and probably some discussion about maintenance once the mappings are installed. My fault - I let this one drop. |
Output
A list of Reactome complexes - does the complex have an active subunit - in which pathways does the complex catalyze a reaction
The text was updated successfully, but these errors were encountered: