-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add options to connect to database for c. annotation #13
Open
bprize15
wants to merge
11
commits into
genome-nexus:master
Choose a base branch
from
bprize15:feat/add-cdna-endpoints
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ed20752
add options to connect to database for c. annotation
bprize15 9b7755f
revert dockerfile
bprize15 578e945
update to support both reference genomes
bprize15 f556590
update README
bprize15 83db47f
fix readme grammar
bprize15 8a9cfe5
hide hgvs endpoints when no database
bprize15 5fb4351
update config
bprize15 0516624
revert fasta file version changes
bprize15 84586cb
revert fasta file version changes again
bprize15 5a4b0ee
fix fasta file version last time
bprize15 9903e84
fix fork count
bprize15 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,7 +44,7 @@ public void getVepAnnotation( | |
try { | ||
out = response.getOutputStream(); | ||
response.setContentType("application/json"); | ||
vepRunner.run(Arrays.asList(region + "/" + allele), false, responseTimeout, out); | ||
vepRunner.run(Arrays.asList(region + "/" + allele), false, responseTimeout, out, false); | ||
} catch (IOException | InterruptedException | VepLaunchFailureException e) { | ||
e.printStackTrace(); | ||
// TODO: throw and handle errors with global exception handler | ||
|
@@ -83,7 +83,7 @@ public void fetchVepAnnotationByRegionsPOST( | |
try { | ||
out = response.getOutputStream(); | ||
response.setContentType("application/json"); | ||
vepRunner.run(regions, true, responseTimeout, out); | ||
vepRunner.run(regions, true, responseTimeout, out, false); | ||
} catch (IOException | InterruptedException | VepLaunchFailureException e) { | ||
e.printStackTrace(); | ||
// TODO: throw and handle errors with global exception handler | ||
|
@@ -98,4 +98,67 @@ public void fetchVepAnnotationByRegionsPOST( | |
return; | ||
} | ||
|
||
@RequestMapping(value = "/vep/human/hgvsc/{hgvsc}", | ||
method = RequestMethod.GET, | ||
produces = "application/json") | ||
@ApiOperation(value = "Retrieves VEP results for single c. variant specified in hgvs syntax (https://ensembl.org/info/docs/tools/vep/vep_formats.html)", | ||
nickname = "fetchVepHgvscAnnotationByGET") | ||
public void getVepHgvscAnnotation( | ||
@ApiParam(value="ENST00000618231.3:c.9G>C", required=true) | ||
@PathVariable | ||
String hgvsc, | ||
@ApiParam("Maximum time (in seconds) to let VEP construct a response (0 = no limit)") | ||
@RequestParam(defaultValue = "0") | ||
Integer responseTimeout, | ||
HttpServletResponse response) { | ||
OutputStream out = null; | ||
try { | ||
out = response.getOutputStream(); | ||
response.setContentType("application/json"); | ||
vepRunner.run(Arrays.asList(hgvsc), false, responseTimeout, out, true); | ||
} catch (IOException | InterruptedException | VepLaunchFailureException e) { | ||
e.printStackTrace(); | ||
// TODO: throw and handle errors with global exception handler | ||
} finally { | ||
try { | ||
response.flushBuffer(); | ||
} catch (Throwable e) { | ||
e.printStackTrace(); | ||
// TODO: throw and handle errors with global exception handler | ||
} | ||
} | ||
} | ||
|
||
@RequestMapping(value = "/vep/human/hgvsc", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here, should we hide or disable this endpoint when no database? |
||
method = RequestMethod.POST) | ||
@ApiOperation(value = "Retrieves VEP results for multiple c. variants specified in hgvs syntax (https://ensembl.org/info/docs/tools/vep/vep_formats.html)", | ||
nickname = "fetchVepHgvscAnnotationsByPOST") | ||
public void fetchVepHgvscAnnotationsPOST( | ||
@ApiParam(value = "List of variants in ENSEMBL hgvsc format. For example:\n" + | ||
"[\"ENST00000618231.3:c.9G>C\", \"ENST00000471631.1:c.28_33delTCGCGG\"]", | ||
required = true) | ||
@RequestBody | ||
List<String> hgvscStrings, | ||
@ApiParam("Maximum time (in seconds) to let VEP construct a response (0 = no limit)") | ||
@RequestParam(defaultValue = "0") | ||
Integer responseTimeout, | ||
HttpServletResponse response) { | ||
OutputStream out = null; | ||
try { | ||
out = response.getOutputStream(); | ||
response.setContentType("application/json"); | ||
vepRunner.run(hgvscStrings, true, responseTimeout, out, true); | ||
} catch (IOException | InterruptedException | VepLaunchFailureException e) { | ||
e.printStackTrace(); | ||
// TODO: throw and handle errors with global exception handler | ||
} finally { | ||
try { | ||
response.flushBuffer(); | ||
} catch (Throwable e) { | ||
e.printStackTrace(); | ||
// TODO: throw and handle errors with global exception handler | ||
} | ||
} | ||
return; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
database.host = ensembldb.ensembl.org | ||
database.port = 5306 | ||
database.user = anonymous | ||
database.password = |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since database is optional, should we hide or disable this endpoint when no database?