add ruqola (RocketChat client) #895
Conversation
There was a problem hiding this comment.
Thanks for your contribution! It needs a few fixes before it can go in.
Please read: https://wiki.gentoo.org/wiki/Project:KDE/Coding_style
Setup your local clone and add your sign-off: https://wiki.gentoo.org/wiki/GitHub_Pull_Requests#Repository.27s_user_configuration
net-im/ruqola/ruqola-1.2.2.ebuild
Outdated
| DEPEND="dev-qt/qtwebsockets[ssl] | ||
| dev-qt/qtgui | ||
| dev-qt/qtwidgets | ||
| dev-qt/qtnetworkauth | ||
| dev-qt/qttest | ||
| dev-qt/qtmultimedia[widgets] |
There was a problem hiding this comment.
- All of those are missing pinning to
SLOT 5and should be sorted alphanumerically - Please start dependencies list in a new line after
DEPEND=" - List of Qt dependencies is missing at least
dev-qt/qtnetwork:5(maybe with[ssl]too considering you added that to qtwebsockets)
There was a problem hiding this comment.
Regarding SLOT and DEPEND: Done.
Regarding qtnetwork dependency: qtnetwork[ssl] is inherited by qtwebsocket[ssl]. Do you think it should be listed anyway?
There was a problem hiding this comment.
Please add direct dependencies if they're accurate, yeah. Ignore anything which happens to be added indirectly.
net-im/ruqola/ruqola-1.2.2.ebuild
Outdated
| kde-frameworks/sonnet | ||
| kde-frameworks/ktextwidgets | ||
| kde-frameworks/knotifyconfig | ||
| keyring? ( dev-libs/qtkeychain ) |
There was a problem hiding this comment.
You probably need to depend on this with a slot operator to trigger rebuild on subslot bump, see:
$ eshowkw qtkeychain
Keywords for dev-libs/qtkeychain:
| | u |
| a a p s a r | n |
| m r h p p s l i i m m | e u s | r
| d a m p p c a x 3 p a s 6 i | a s l | e
| 6 r 6 p p 6 r 8 9 h 6 c 8 p | p e o | p
| 4 m 4 a c 4 c 6 0 a 4 v k s | i d t | o
----------+-----------------------------+---------+-------
0.10.0 | + o + o o ~ o + o o o o o o | 7 o 0/1 | gentoo
[I]0.11.1 | ~ o ~ o o ~ o ~ o o o o o o | 7 o | gentoo
There was a problem hiding this comment.
@mattenklicker What do you mean?
No description provided.