-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kde-misc/kio-admin: new package, add 9999 #998
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Which
kde*-meta
package would it best fit into?
SLOT="6" | ||
|
||
DEPEND=" | ||
>=dev-qt/qtbase-${QTMIN}:6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for any USEdeps here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only Core searched for by find_package. I dont see it linking explicitly to any Qt library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see linking to Qt6DBus as well as Qt6Gui.
1123850
to
aa5db4c
Compare
For what I can see kde-misc has been used for all the KIO workers. Only exceptions are dev-util/kio-perldoc and net-misc/kio-zeroconf |
yes, kde-*/ categories are deprecated, but I was more asking about your thoughts on where to reference it from |
kdeadmin-meta does seem the most reasonable. |
SLOT="6" | ||
|
||
DEPEND=" | ||
>=dev-qt/qtbase-${QTMIN}:6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see linking to Qt6DBus as well as Qt6Gui.
abb3f83
to
6e406b5
Compare
app-admin/kio-admin/metadata.xml
Outdated
<name>Gentoo KDE Project</name> | ||
</maintainer> | ||
<upstream> | ||
<bugs-to>https://bugs.kde.org/</bugs-to> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<bugs-to>https://bugs.kde.org/</bugs-to> | |
<bugs-to>https://bugs.kde.org/enter_bug.cgi?product=kio-admin</bugs-to> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you intend that other packages in tree also follow this convention?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where possible and where we stumble over it, yes. @thesamesam?
KEYWORDS="" | ||
|
||
DEPEND=" | ||
>=dev-qt/qtbase-${QTMIN}:6[dbus,gui,network,xml] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you establish Qt6Network
and Qt6Xml
all of a sudden?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Included libraries that I saw kio-admin link against. With headers I only see explicit usage of dbus and widgets
ldd /usr/libexec/kf6/kio-admin-helper /usr/lib64/qt6/plugins/kf6/kio/admin.so /usr/lib64/qt6/plugins/kf6/kfileitemaction/kio-admin.so | grep libQt
libQt6DBus.so.6 => /usr/lib64/libQt6DBus.so.6 (0x000070427508b000)
libQt6Core.so.6 => /usr/lib64/libQt6Core.so.6 (0x0000704274800000)
libQt6Network.so.6 => /usr/lib64/libQt6Network.so.6 (0x0000704273c00000)
libQt6Xml.so.6 => /usr/lib64/libQt6Xml.so.6 (0x0000704274eb3000)
libQt6Gui.so.6 => /usr/lib64/libQt6Gui.so.6 (0x0000704271e00000)
libQt6DBus.so.6 => /usr/lib64/libQt6DBus.so.6 (0x0000795e76591000)
libQt6Core.so.6 => /usr/lib64/libQt6Core.so.6 (0x0000795e75e00000)
libQt6Network.so.6 => /usr/lib64/libQt6Network.so.6 (0x0000795e75200000)
libQt6Xml.so.6 => /usr/lib64/libQt6Xml.so.6 (0x0000795e76498000)
libQt6Gui.so.6 => /usr/lib64/libQt6Gui.so.6 (0x0000795e73200000)
libQt6Gui.so.6 => /usr/lib64/libQt6Gui.so.6 (0x00007132cde00000)
libQt6Core.so.6 => /usr/lib64/libQt6Core.so.6 (0x00007132cd600000)
libQt6Network.so.6 => /usr/lib64/libQt6Network.so.6 (0x00007132cca00000)
libQt6Widgets.so.6 => /usr/lib64/libQt6Widgets.so.6 (0x00007132cbc00000)
libQt6DBus.so.6 => /usr/lib64/libQt6DBus.so.6 (0x00007132cd122000)
libQt6Xml.so.6 => /usr/lib64/libQt6Xml.so.6 (0x00007132cd55e000)
libQt6WaylandClient.so.6 => /usr/lib64/libQt6WaylandClient.so.6 (0x00007132ca6f3000)
Edit: Decided to use the headers as the final on what should be included as use flags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ldd is giving you linkage of deps, only use lddtree for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see now.
So QtGui is linked due to https://github.com/KDE/kio-admin/blob/a2eb7c0783326f8f02c70fad38ea0648d5054786/src/fileaction/fileaction.cpp#L4. I see usage of QWidget though as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. Do you want to fix that upstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to be absolutely sure, you could always build qtbase without any USE flags and gradually add USE flags to the ebuild and to the installed qtbase package, each time you build kio-admin and it complains.
I have done this a few times. It helps to save binpackages as you'll likely end up recompiling quite a bunch of times otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. Do you want to fix that upstream?
6e406b5
to
83007e8
Compare
Signed-off-by: Alfred Wingate <[email protected]>
83007e8
to
b5219c6
Compare
No description provided.