Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start implementation of point cloud layer #96

Merged
merged 11 commits into from
Feb 2, 2024
Merged

Start implementation of point cloud layer #96

merged 11 commits into from
Feb 2, 2024

Conversation

naomatheus
Copy link
Collaborator

Getting started

naomatheus
naomatheus commented Jan 19, 2024
View reviewed changes
src/point-cloud-layer.ts Outdated Show resolved Hide resolved
@naomatheus
base pointcloud layer. TODO: verify accessors in PointCloudLayerProps…
c8797e8 
…, TODO: verify accessor methods in PointCloudLayer's render methods
@naomatheus
Copy link
Collaborator Author

@kylebarron

I still need to actually use the NormalAccessor. But I need to read up on that Re: developmentseed/lonboard#322 (comment)

@naomatheus naomatheus changed the title DRAFT: Start implementation of point cloud layer Start implementation of point cloud layer Jan 25, 2024
@kylebarron
Copy link
Member

You need to merge in or rebase on the latest main branch to resolve your merge conflicts

@naomatheus
Copy link
Collaborator Author

GTG
LGTU @kylebarron ?

@kylebarron
Copy link
Member

It would also be great to create a minimal example in the same form as the existing examples directory so we can at least have a manual workflow to test that the layer works.

kylebarron
kylebarron reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@kylebarron kylebarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just two small comments and then ready to go

src/point-cloud-layer.ts Outdated Show resolved Hide resolved
src/point-cloud-layer.ts Show resolved Hide resolved
@naomatheus
Copy link
Collaborator Author

Awaiting last review for this PR @kylebarron

@kylebarron kylebarron merged commit bfde800 into main Feb 2, 2024
1 check passed
@kylebarron kylebarron deleted the matt/pointcloud-layer branch February 2, 2024 16:00
@kylebarron
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylebarron kylebarron kylebarron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naomatheus @kylebarron