Add support for displaying municipality in AzureMaps autocomplete results #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that the autocomplete functionality in the AzureMaps provider was missing the ability to display the municipality (city). This was causing incomplete location suggestions, as cities were not included in the results.
To fix this, we added the following line to the formatGeocodeResponse function:
$builder->setLocality($result->address->municipality ?? null);Now, when searching for an address like Via Giuseppe Garibaldi 62, IT, Italy, the autocomplete properly returns results that include city names. This improves the accuracy and usability of the geocoding provider.
Let us know if any adjustments are needed! 🚀