Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Chapter 8 - mapping #19

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

[WIP] Chapter 8 - mapping #19

wants to merge 12 commits into from

Conversation

asinghvi17
Copy link
Collaborator

this may be my favourite chapter ;)

@asinghvi17 asinghvi17 marked this pull request as draft September 20, 2024 23:41
@asinghvi17 asinghvi17 force-pushed the as/08-mapping branch 2 times, most recently from 7b0e823 to a95bd50 Compare September 21, 2024 00:20
chapters/08-mapping.qmd Outdated Show resolved Hide resolved
chapters/08-mapping.qmd Show resolved Hide resolved
In this chapter, we provide a comprehensive summary of the most useful workflows of these two methods for creating static maps (@sec-static-maps).
Static maps can be easily shared and viewed (whether digitally or in print), however they can only convey as much information as a static image can.
Interactive maps provide much more flexibilty in terms of user experience and amount of information, however they often require more work to design and effectively share.
Thus, in @sec-interactive-maps, we move on to elaborate on the `.explore` method for creating interactive maps, which was also briefly introduced earlier in @sec-vector-layers.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may not need to split static/interactive into sections as there's little difference

Copy link

netlify bot commented Sep 22, 2024

Deploy Preview for courageous-phoenix-f7cc3c ready!

Name Link
🔨 Latest commit 4a68e7d
🔍 Latest deploy log https://app.netlify.com/sites/courageous-phoenix-f7cc3c/deploys/66f1db7a1071760008e6c1bc
😎 Deploy Preview https://deploy-preview-19--courageous-phoenix-f7cc3c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asinghvi17
Copy link
Collaborator Author

@Nowosad it looks like the Netlify preview isn't working for this PR?

https://deploy-preview-19--courageous-phoenix-f7cc3c.netlify.app/

@Nowosad
Copy link
Member

Nowosad commented Sep 22, 2024

@asinghvi17 yes -- because the render failed, see https://github.com/geocompx/geocompjl/actions/runs/10983624666/job/30493218544?pr=19: in short, the issue is that you call the data as data/, but this path is relative to the .qmd file location (thus is searches for chapters/data/...). There are possibly three options: 1) move chapter .qmd files to the main project directory, 2) use the ../ prefix, or 3) do some Julia magic ;)

@asinghvi17
Copy link
Collaborator Author

It's strange because this was working before, maybe it's an issue with the Quarto setup changing. We set execute-dir for this exact reason in the frontmatter, but that requires a patch in the Julia quarto engine to actually work. Maybe that patch is not being applied?

Copy link

@github-actions github-actions bot temporarily deployed to pull request September 23, 2024 08:30 Inactive
@Nowosad
Copy link
Member

Nowosad commented Sep 23, 2024

@asinghvi17 I think I fixed all of the tiny issues and the PR renders to a preview website!

@asinghvi17
Copy link
Collaborator Author

Thanks @Nowosad! I think I missed that the data path argument had been changed on main :)

@asinghvi17
Copy link
Collaborator Author

I'm thinking about adding some colormap suggestions. What would people think about:

  • :diverging_bwr_40_95_c42_n256 for diverging data
  • :haline, :viridis, or :plasma for linear gradients
  • something else for cyclic data

Copy link

@github-actions github-actions bot temporarily deployed to pull request September 23, 2024 21:26 Inactive
@asinghvi17
Copy link
Collaborator Author

TODOs for tomorrow / later:

  • Make all examples in tabsets have the same number of lines, this way the figure has the same position regardless of which tab you are in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants