260 proofreading changes for c1 #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Robinlovelace
commented
Oct 5, 2024
Robinlovelace
commented
- First tweaks to c1
- Fix quotes
- Fixes to section 1.1
- D -> -dimensional
- Shorten and simplify prose
- Fixes to 1.2
- Update text, high-level
- Quote fixes: " -> single
- The the and other fixes
- Complete proofing c1, close Proofreading changes for c1 #260
02-attribute-operations.qmd
Outdated
| @@ -299,7 +299,7 @@ In the following code example, given the `world_agg3` continent summary (@fig-sp | |||
|
|
|||
| - drop the geometry column, | |||
| - calculate population density of each continent, | |||
| - arrange continents by the number countries they contain, and | |||
| - arrange continents by the number countries each contains, and | |||
There was a problem hiding this comment.
the number of countries, right? @Robinlovelace
There was a problem hiding this comment.
Yes they missed that I think! Fix incoming, thank you
08-mapping.qmd
Outdated
| @@ -493,7 +493,7 @@ For example, here is a plot similar to @fig-faceted-map2, but specifying each pa | |||
|
|
|||
| ```{python} | |||
| #| label: fig-faceted-map3 | |||
| #| fig-cap: 2D layout in a faceted map, using "manual" specification of the panels | |||
| #| fig-cap: Two-dimensional layout in a faceted map, using "manual" specification of the panels | |||
There was a problem hiding this comment.
Right, I just made the same change but now saw you already did it, thanks!
michaeldorman
approved these changes
Oct 5, 2024
|
All seems OK now, will merge |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 5, 2024
…-changes-for-c1 260 proofreading changes for c1 36efc01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.