Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Simplified and minimal update to include pseudo-incompressibility #564

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

BWHindman
Copy link
Contributor

Added the capability to switch from anelastic to the pseudo-incompressible approximation. With pseudo-incompressibility turned off, it has run the hydro anelastic benchmark on Pleiades without throwing errors, but it ran incredible slow. Made as a draft pull to allow other developers to check the implementation.

Copy link
Contributor

@feathern feathern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked at this very carefully, and I believe this is good to go. The implementation looks correct to me both in terms of the code changes and the associated math. I did check the additional terms in the diffusion coefficients, and based on my understanding of what needed to be chain-ruled, they appear correct to me. I'm approving this.

@feathern
Copy link
Contributor

You'll have to set this to a non-draft before I can merge. If you want to wait until Pleiades is up so we can test the speed once more, that's fine with me. Everything you described offline sounds like one of your nodes had a memory problem.

@BWHindman BWHindman marked this pull request as ready for review July 15, 2024 20:29
@BWHindman
Copy link
Contributor Author

I believe that I hit all the correct buttons to convert this pull request from a draft to a "ready to merge" request. Should be good to go.

@feathern
Copy link
Contributor

Great. I just ran some tests to be extra sure, and there is no measurable speed difference between your version and the main-branch version of Rayleigh. I suspect what you saw on the NASA systems was just another symptom of the old hardware.

@feathern feathern merged commit 8445fab into geodynamics:main Jul 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants