Bug Fix: Diagnostics and Second Radial Derivatives when Using Finite-Difference Mode #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot to update the dependencies file originally. I just did, and now the tests pass. |
|
@rpvin Maybe that fixes your crashes? |
tukss
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug related to finite-difference mode. When diagnostic output quantities are requested that require a second radial derivative, that derivative is calculated at output time. The subroutine that handles the derivative calculations at output time was lacking any logic that would call the appropriate finite-difference derivative routine. Instead, a Chebyshev derivative routine was called, which caused a crash because the Chebyshev grid object had not been initialized. This PR fixes this bug by adding appropriate finite-difference logic to Diagnostics_Second_Derivatives.F90.