Added finite-difference support to the log_deriv subroutine. #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a missing if guard around the deallocate. I've pushed that directly to your branch. |
|
Good catch. I just moved the deallocate statement into the main Chebyshev "if" block to save a couple of lines of code + keep related things together. |
|
That looks good. I'm just running some tests here and will approve this later today if all goes well. |
|
It seems to work fine with gfortran but I'm getting a floating-point overflow after the first time step with the Intel compiler (the new LLVM based one). I'm investigating where this comes from. |
|
OK. That seems to have been some bad interaction of Cray libsci as the LAPACK provider and the |
|
Great -- thanks for checking that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the finite-difference part of issue #570 reported by @rpvin . Please try this out when you get a chance to see if initialization now works properly for custom reference states with FD turned on.