Rename registry functions

geojupyter · Jul 1, 2024 · a92a688 · a92a688
1 parent 19fc68e
commit a92a688
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 9 deletions.
diff --git a/packages/base/src/commands.ts b/packages/base/src/commands.ts
@@ -133,7 +133,7 @@ namespace Private {
       const dialog = new Dialog({
         body: new LayerBrowserWidget(
           current.context.model,
-          layerBrowserRegistry.getProviders()
+          layerBrowserRegistry.getRegistryLayers()
         ),
         buttons: [Dialog.cancelButton(), Dialog.okButton()]
       });

diff --git a/packages/base/src/tools.ts b/packages/base/src/tools.ts
@@ -186,7 +186,7 @@ export function createDefaultLayerRegistry(
 
     if ('url' in xyzprovider) {
       const tile = convertToRegistryEntry(entry, xyzprovider);
-      layerBrowserRegistry.registerProvider(tile);
+      layerBrowserRegistry.addRegistryLayer(tile);
     } else {
       Object.keys(xyzprovider).forEach(mapName => {
         const tile = convertToRegistryEntry(
@@ -195,11 +195,11 @@ export function createDefaultLayerRegistry(
           entry
         );
 
-        layerBrowserRegistry.registerProvider(tile);
+        layerBrowserRegistry.addRegistryLayer(tile);
       });
     }
 
-    console.log('register', layerBrowserRegistry.getProviders());
+    console.log('register', layerBrowserRegistry.getRegistryLayers());
   }
 
   // TODO: These need better names

diff --git a/packages/schema/src/interfaces.ts b/packages/schema/src/interfaces.ts
@@ -201,6 +201,8 @@ export interface IRasterLayerGalleryEntry {
 }
 
 export interface IJGISLayerBrowserRegistry {
-  getProviders(): IRasterLayerGalleryEntry[];
-  registerProvider(data: IRasterLayerGalleryEntry): void;
+  getRegistryLayers(): IRasterLayerGalleryEntry[];
+  addRegistryLayer(data: IRasterLayerGalleryEntry): void;
+  removeRegistryLayer(name: string): void;
+  clearRegistry(): void;
 }
diff --git a/python/jupytergis_core/src/layerBrowserRegistry.ts b/python/jupytergis_core/src/layerBrowserRegistry.ts
@@ -12,15 +12,15 @@ export class JupyterGISLayerBrowserRegistry
     this._registry = [];
   }
 
-  getProviders(): IRasterLayerGalleryEntry[] {
+  getRegistryLayers(): IRasterLayerGalleryEntry[] {
     return [...this._registry];
   }
 
-  registerProvider(data: IRasterLayerGalleryEntry): void {
+  addRegistryLayer(data: IRasterLayerGalleryEntry): void {
     this._registry.push(data);
   }
 
-  removeProvider(name: string): void {
+  removeRegistryLayer(name: string): void {
     this._registry = this._registry.filter(item => item.name !== name);
   }