Vector symbology api #163
Merged
Vector symbology api #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gjmooney
force-pushed
the
vector_symbology_api
branch
from
5dd3a54 to
daf25ab
Compare
martinRenou
approved these changes
Oct 1, 2024
| # TODO Load source-layer properly, from qgis symbology? | ||
| try: | ||
| source_layer = get_source_layer_names(url)[0] | ||
| layer_parameters["sourceLayer"] = source_layer | ||
| except ValueError: | ||
| pass | ||
| # TODO Load style properly | ||
|
|
||
| layer_parameters.update(type="fill") |
There was a problem hiding this comment.
I'm pretty sure the source_layer stuff isn't being used anywhere right now, so it should be fine to get rid of. The type is required in the schema so we should leave that for now.
There was a problem hiding this comment.
Ok! Thanks for your answer
Let's merge this then!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
geojsonnotebook API to use color expressions. Also loads colors for vector tile layers fromqgzfiles, and exports color information when exporting toqgz.