Embed GeoJSON schema in the project to improve build reliability

[arjxn-py]

Should fix #125

[github-actions]

👈 Launch a Binder on branch arjxn-py/jupytergis/geojson-schema

[martinRenou]

Thanks for opening a PR! Although I kind of disagree with the fix. EDIT: I disagree because we're embedding code that is not ours here, it would be prone to error if it gets edited by mistake. We should rely on the official implementation and not copy paste it in our project.

I'd be more in favor of an approach to:

• Download the schema once
• Store it somewhere that is not cleaned with jlpm run clean and not tracked by git
• Don't download it again if it's already there

That way you need an internet connection for the first build, but you don't need it anymore for subsequent builds.

[arjxn-py]

Thanks @martinRenou, I agree with your idea and just want to confirm a couple of things that -

• Do we want to download the schema once while building the extension (or while loading geojson layer) if base schema is not already there?
• Would this implementation be something similar like thumbnails for raster layers thing?

[martinRenou]

Do we want to download the schema once while building the extension (or while loading geojson layer) if base schema is not already there?

Once when building the application (we need the schemas to generate some Python interfaces as of today).

Would this implementation be something similar like thumbnails for raster layers thing?

Yes that could be similar 👍🏽

[github-actions]

Preview PR at appsharing.space

[github-actions]

Integration tests repot: appsharing.space

[arjxn-py]

Oh oops i pushed in wrong branch

[martinRenou]

Thanks!