-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local and external file loading support for geojson, image and shapefile sources #256
Local and external file loading support for geojson, image and shapefile sources #256
Conversation
👈 Launch a Binder on branch arjxn-py/jupytergis/#246-unified-external-file-handling |
for more information, see https://pre-commit.ci
Docs preview: appsharing.space |
Integration tests report: appsharing.space |
Preview using JupyterLite: appsharing.space |
Hi, would you have some tip/suggestion on how and from where do i download small enough raster/hillshade/vector tile layer for local testing? It'd be really awesome if any of those files would also be served somewhere so that it's url could also be used to cross check I struggle to use the sources from sample jgis files as unlike for image/geojson files the other source urls are like - |
|
For tileservers you can use GDAL to download the data and build a GeoTIFF, though it's a bit fiddly: https://gis.stackexchange.com/a/417756 |
Thanks a lot @mfisher87, this is helpful. I'd definitely explore these to get some data :) |
Happy to help! |
If it's the geotiff only you're referring to, I think I have the required geotiff file from the sample .jgis file. Tho I've halted the logic for geotiff due to some recent changes in that logic to implement caching. I may also break this PR in parts to include that data source in a separate one. |
16f4992
to
e05d329
Compare
7ab53a5
to
e0ed531
Compare
a418d44
to
d75a9b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of nitpicky comments + GeoJSONSource by URL, otherwise I think it looks good!
Co-authored-by: martinRenou <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
In the direction of #246 for which this PR defines a generic method for listed data sources along with local file support.