Configure lerna to use jlpm as npm client
#279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarn is bundled at the correct version with jlpm; installing it separately can cause trouble!
|
|
|
Preview using JupyterLite: appsharing.space |
|
Integration tests report: appsharing.space |
|
Docs preview: appsharing.space |
mfisher87
commented
Dec 30, 2024
|
|
||
| ``jlpm run watch`` will sit and wait for a change once started. Edit a file | ||
| to trigger a build. | ||
|
|
There was a problem hiding this comment.
This was true before this PR, but noticed it again during testing and figured it deserved a callout in the docs since it's a bit different behavior from most other "watch" tools I've used.
brichet
reviewed
Jan 2, 2025
There was a problem hiding this comment.
Looks good, thanks @mfisher87
Should we also update the workflows for consistency ?
|
Are you referring to GitHub Actions workflows? I think yes, but that feels like a larger undertaking and less urgent. I'd like to prioritize that work separately from this PR if y'all agree! |
|
👍 let's postpone it. |
brichet
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #253
Our contributing docs included instructions to install yarn at a specific version.
jlpmcomes bundled with the correct version of yarn, so we don't need that! This change simplifies environment setup.Check links is currently broken due to an upstream bug. See #278