Refactor layer tree updates #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Integration tests report: appsharing.space |
gjmooney
force-pushed
the
fix_layer_tree_stuff
branch
from
241a9e6 to
5ed6d5e
Compare
brichet
reviewed
Jan 6, 2025
gjmooney
force-pushed
the
fix_layer_tree_stuff
branch
from
ee03c6f to
0ba1ff2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies how layer tree updates are handled, basically it changes
_addLayerTreeItem,_removeLayerTreeLayer, and_removeLayerTreeGroupto modify a working copy of the layer tree, and then syncs the changes with they.jsdocument so only the final version of the layer tree is used when firing relevant signals, instead of triggering the signals on intermediate changes.This should fix the inputs to the changes made in #269.
📚 Documentation preview: https://jupytergis--284.org.readthedocs.build/en/284/
💡 JupyterLite preview: {docs-pre-index-url}/lite