Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python 3.13 & Drop support for 3.8 and 3.9 #303

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Support Python 3.13 & Drop support for 3.8 and 3.9 #303

wants to merge 6 commits into from
+22 −11

Conversation

arjxn-py
Copy link
Contributor

@arjxn-py arjxn-py commented Jan 10, 2025 •
edited by github-actions bot
Loading

Shall close #299

Checklist

  • PR has a descriptive title and content.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--303.org.readthedocs.build/en/303/
💡 JupyterLite preview is available from the doc, by clicking on lite badge

@arjxn-py arjxn-py marked this pull request as draft January 10, 2025 09:52
@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch arjxn-py/jupytergis/python-313

mfisher87
mfisher87 reviewed Jan 11, 2025
View reviewed changes
.github/workflows/build.yml
@@ -10,6 +10,9 @@ jobs:
build:
name: Build jupytergis
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.10", "3.11", "3.12", "3.13"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do folks feel about testing only the oldest and newest versions we support? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me 👍🏽

@arjxn-py
Copy link
Contributor Author

As an update to the original issue regarding extending support for Python 3.13, this is an FYI that we can currently only support Python up to version 3.12. The Python 3.13 migration is still ongoing, as tracked here: Python 3.13 Migration Status.

It appears that the migration is currently blocked on the following issue in the pyqt-feedstock repository:
conda-forge/pyqt-feedstock#141

Until this is resolved, the QGIS feedstock cannot be updated to support Python 3.13.

We can keep the original issue open irrespective of the merge of this PR. However, for now, we can test CI on Python 3.10 and 3.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou left review comments

@mfisher87 mfisher87 mfisher87 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Python 3.13; drop support for 3.8 and 3.9?
3 participants
@arjxn-py @mfisher87 @martinRenou