-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image and video support #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat!
Couple of comments (we can resolve this in follow-up PRs):
- it would be great to have a Python API for this too
add_video
/add_image
- it would be nice to have a toolbar button for image layer and one for video layer which allows creating both the source and the layer at once
- I'm seeing this in the form, I'm not sure if it has to do with my recent PR Improve form CSS #74 or if it's related to yours
Concerning the form rendering issue, those big buttons that are messing up the rendering should actually be removed by the logic in https://github.com/QuantStack/jupytergis/blob/main/packages/base/src/formbuilder/objectform/baseform.tsx#L128 For a bit of contexts, those buttons are for editing arrays (removing items, moving items around, adding items). We have this logic to remove those buttons because it does not quite make sense to reorder or add/remove items from the arrays in our case. |
Ah I guess it's because your coordinates is an array of arrays and we're not handling that case when removing the array edit buttons. |
46fd905
to
cb18965
Compare
I plan on refactoring our commands a bit (something like this) and wanted to use that as a chance to make sure the toolbar/context menus have all the options we've implemented so far.
I was able to apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Working towards #11. Adds image and video layers and sources.