Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a wrong comparison handling the unused statut of a source #80

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Fix a wrong comparison handling the unused statut of a source #80

merged 2 commits into from
Jul 30, 2024

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Jul 30, 2024

Fixes #67

@brichet brichet added the bug Something isn't working label Jul 30, 2024
@brichet brichet requested a review from martinRenou July 30, 2024 08:55
@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch brichet/jupytergis/fix_undo_unused_source

martinRenou
martinRenou approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brichet brichet merged commit 0762f88 into geojupyter:main Jul 30, 2024
10 checks passed
@brichet brichet deleted the fix_undo_unused_source branch July 30, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undo removal of layer does not re-render the source panel
2 participants
@brichet @martinRenou