Me image input preview #1104
Me image input preview #1104
Conversation
|
Affected libs:
|
|
📷 Screenshots are here! |
LHBruneton-C2C
force-pushed
the
ME-image-input-preview
branch
from
b5ff5e9 to
b36749c
Compare
LHBruneton-C2C
force-pushed
the
ME-image-input-preview
branch
from
b36749c to
1384e57
Compare
LHBruneton-C2C
force-pushed
the
ME-image-input-preview
branch
from
a079e23 to
9b472bc
Compare
| <gn-ui-text-input | ||
| *ngIf="showAltTextInput" | ||
| [placeholder]="'input.image.altTextPlaceholder' | translate" | ||
| [value]="altText ?? ''" | ||
| (valueChange)="handleAltTextChange($event)" | ||
| extraClass="gn-ui-editor-textarea" | ||
| [disabled]="disabled" | ||
| [disabled]="true" |
There was a problem hiding this comment.
I am wondering why we show the alt text and the button add alt text if we cannot modify it?
There was a problem hiding this comment.
I have read the comments in the ticket, it looks like we are going to fix in another PR?
There was a problem hiding this comment.
Because we should be able to modify it, it was initially developed that way. But now it's broken, and we need to release a version really soon.
There was a problem hiding this comment.
Thanks you for the PR, nice rendering! I don't know if an e2e test is worth here adding here, maybe?
This is not related to your work but:
- I can select any type of file (it won't upload but there is no error nor warning)
- when entering an url i cant click on Select image anymore, i am stuck with the url (also there are no error nor warning when the url is not working)
- regarding accessibility: when clicking on the full size button, there is no close button on the overlay, also i cannot escape/close the overview with the keyboard
- "Overviews" title is plural but i cannot add multiple images?
|
@AlitaBernachot Thanks for your thorough testing and your feedback. I'll put it in the dedicated Confluence page, so we keep it in mind. |
Description
This PR changes the image input component, to use the same image preview as in the datahub (thumbnail + fullscreen). This way, the user can view the full image, and gets an idea of the final display in the datahub.
Also, the alternative text input is disabled, as changing it breaks the overview link.
Architectural changes
The image-input component has been moved to the ui-elements lib, to allow the use of the image-overlay-preview component.
Screenshots
Quality Assurance Checklist
breaking changelabelbackport <release branch>label