-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support writing datetime columns #120
Support writing datetime columns #120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @theroggy !
Please also update docs/known_issues.md
to note that it is now possible to write datetime values, but only at ms
precision. Also probably a good idea to note that some drivers do not support full datetime and may instead store only date values (e.g., shapefile); we may further want to note that if needed to store the original values, they should encode them to a string (it seems the recommendation to store full datetime values is to put them in a string)
Co-authored-by: Joris Van den Bossche <[email protected]>
…y/pyogrio into support-writing-datetime
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @theroggy , this is great to have in place for 0.4.0
Closes #58