Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support writing datetime columns #120

Merged
merged 13 commits into from
Jun 8, 2022

Conversation

theroggy
Copy link
Member

@theroggy theroggy commented Jun 6, 2022

Closes #58

@theroggy theroggy marked this pull request as draft June 6, 2022 22:24
@theroggy theroggy marked this pull request as ready for review June 6, 2022 23:05
@theroggy theroggy marked this pull request as draft June 7, 2022 06:08
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

pyogrio/_io.pyx Outdated Show resolved Hide resolved
pyogrio/_io.pyx Outdated Show resolved Hide resolved
pyogrio/_io.pyx Outdated Show resolved Hide resolved
pyogrio/tests/test_raw_io.py Show resolved Hide resolved
Copy link
Member

@brendan-ward brendan-ward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @theroggy !

Please also update docs/known_issues.md to note that it is now possible to write datetime values, but only at ms precision. Also probably a good idea to note that some drivers do not support full datetime and may instead store only date values (e.g., shapefile); we may further want to note that if needed to store the original values, they should encode them to a string (it seems the recommendation to store full datetime values is to put them in a string)

@theroggy theroggy changed the title Support writing datetime columns in write_dataframe Support writing datetime columns Jun 7, 2022
@theroggy theroggy marked this pull request as ready for review June 7, 2022 16:07
@theroggy
Copy link
Member Author

theroggy commented Jun 8, 2022

Thanks for working on this @theroggy !

Please also update docs/known_issues.md to note that it is now possible to write datetime values, but only at ms precision. Also probably a good idea to note that some drivers do not support full datetime and may instead store only date values (e.g., shapefile); we may further want to note that if needed to store the original values, they should encode them to a string (it seems the recommendation to store full datetime values is to put them in a string)

Done.

Copy link
Member

@brendan-ward brendan-ward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @theroggy , this is great to have in place for 0.4.0

@brendan-ward brendan-ward merged commit 99d382e into geopandas:main Jun 8, 2022
@theroggy theroggy deleted the support-writing-datetime branch June 8, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: support writing datetime columns in write_dataframe
3 participants