Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: raise specific error when trying to read non-UTF-8 file with use_arrow #490

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

theroggy
Copy link
Member

@theroggy theroggy commented Oct 20, 2024

Reading non-UTF-8 encoded files (e.g. .csv or .shp files) with use_arrow=True is not supported, but it is typically supported with use_arrow=False.

This PR changes the exception thrown so the advice to use use_arrow=False is given when appropriate:

raise DataSourceError("The file being read is not encoded in UTF-8; please use_arrow=False")

@theroggy theroggy marked this pull request as draft October 20, 2024 11:31
@theroggy theroggy closed this Jan 26, 2025
@theroggy theroggy reopened this Jan 26, 2025
@theroggy theroggy changed the title TST: enable csv tests for use_arrow ENH: raise specific error when trying to read non-UTF-8 file with use_arrow Jan 26, 2025
@theroggy theroggy marked this pull request as ready for review January 26, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant