Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix defunct processes #333

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Fix defunct processes #333

merged 2 commits into from
Feb 12, 2025

Conversation

danduk82
Copy link
Contributor

@danduk82 danduk82 commented Feb 11, 2025

the problem of defunct (zombie) process is a bad escapement of the & in the url to be accessed by curl in an healthcheck with url parameters. This PR escapes the url by adding 2 little '' characters, which caused way more headhaches to find than expected.

@jeanmi151 jeanmi151 self-requested a review February 11, 2025 18:25
Copy link
Contributor

@jeanmi151 jeanmi151 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@jeanmi151
Copy link
Contributor

@f-necas should we port this into other branches ?

@fvanderbiest
Copy link
Member

fvanderbiest commented Feb 12, 2025

Can we change the test URL at the same time ?

We'd be better with something like /geoserver/ows?SERVICE=WMS&LAYERS=geor:public_layer&FORMAT=image/png&VERSION=1.3.0&SLD_VERSION=1.1.0&REQUEST=GetMap&CRS=EPSG:3857&BBOX=-20820223,-20820223,20820223,20820223&WIDTH=10&HEIGHT=10 (this layer is provided by https://github.com/georchestra/geoserver_minimal_datadir/tree/master/workspaces/geor/automated_tests/public_layer

@jeanmi151 jeanmi151 self-assigned this Feb 12, 2025
@jeanmi151
Copy link
Contributor

done, tested and working

@jeanmi151 jeanmi151 added backport-to-24.0 backport-to-25.0 for backporting function labels Feb 12, 2025
@jeanmi151 jeanmi151 merged commit d190ef1 into georchestra:master Feb 12, 2025
2 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 12, 2025
---------

Co-authored-by: Jean-Michel Crepel <[email protected]>
(cherry picked from commit d190ef1)
github-actions bot pushed a commit that referenced this pull request Feb 12, 2025
---------

Co-authored-by: Jean-Michel Crepel <[email protected]>
(cherry picked from commit d190ef1)
Copy link

💚 All backports created successfully

Status Branch Result
24.0
25.0

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

jeanmi151 pushed a commit that referenced this pull request Feb 12, 2025
---------

Co-authored-by: Jean-Michel Crepel <[email protected]>
(cherry picked from commit d190ef1)
jeanmi151 pushed a commit that referenced this pull request Feb 12, 2025
---------

Co-authored-by: Jean-Michel Crepel <[email protected]>
(cherry picked from commit d190ef1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-24.0 backport-to-25.0 for backporting function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants