accesslog - porting accesslogs capabilities from DT's gateway #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maybe the test should go into the console testsuite instead of here ? |
f-necas
force-pushed
the
main
branch
2 times, most recently
from
74698bf to
4660e3a
Compare
…ion on the MDC The `AccessLogFilter` logs at the `org.georchestra.gateway.accesslog` logging topic, appending additional information to the MDC useful for analysis on collected logs: - route-id - route-uri - remoteAddress - auth-user - auth-roles - X-Request-ID The `RequestIdGlobalFilter` propagates incoming `X-Request-ID` request headers to the downstream services, and returns the same value to the caller.
The effective authentication role names may differ from the authority names given by the authentication provider due to role mappings. Use the effective set of role names as the MDC's auth-roles entry, and add the auth provider role names as principal-roles for the sake of debugging.
pmauduit
force-pushed
the
accesslog-mdc
branch
from
08d6b84 to
2c442ff
Compare
|
force-pushed after having rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow relates to #112
This work has been done on the DT fork but not ported here yet.
TODO:
-Dreactor.netty.http.server.accessLogEnabled=trueshould also be documentedOne test related to rabbitmq event emission is failing, because it expects an output from the console testcontainer, which somehow does not work with the modified logging configuration. There might be something more relevant than parsing the container output as test result, but not sure of what could be a better approach yet.