Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed proxy when PreserveHost filter is enabled and blocked local URLs #119

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

emmdurin
Copy link
Contributor

Adding PreserveHost filter to filter chain prevents proxy for setting Host header to targeted host, then we have to change Host header in proxy filter.
There is also a fix which blocks local URLs access.

@emmdurin emmdurin force-pushed the proxy-preservehost-fix branch from b85f432 to 707c36d Compare April 11, 2024 09:50
@emmdurin emmdurin requested a review from pmauduit April 11, 2024 09:51
@fvanderbiest fvanderbiest requested a review from f-necas April 12, 2024 11:56
Copy link
Collaborator

@f-necas f-necas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested but LGTM

@f-necas
Copy link
Collaborator

f-necas commented Apr 19, 2024

Tested and working in my context !

@emmdurin emmdurin merged commit a4b049a into main Apr 22, 2024
3 checks passed
@f-necas f-necas deleted the proxy-preservehost-fix branch April 23, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants